Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
left a comment
There was a problem hiding this comment.
LGTM with 🟢 CI and the links fixed
| Ubuntu Focal | [](https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-focal-amd64) | ||
| Homebrew | [](https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-homebrew-amd64) | ||
| Windows | [](https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-windows7-amd64) | ||
| Test coverage | [](https://codecov.io/gh/ignitionrobotics/ign-math) |
There was a problem hiding this comment.
Ahh here too we should have caught this earlier. It's all main for the badges
There was a problem hiding this comment.
It's alright, once all the PRs are in, I can do a sweeping regex find and replace
There was a problem hiding this comment.
Just confirming that every badge everywhere is main?
There was a problem hiding this comment.
Every package's main branch should be using main links, yup. Thanks!
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 99.73% 99.90% +0.17%
==========================================
Files 70 46 -24
Lines 6419 4260 -2159
==========================================
- Hits 6402 4256 -2146
+ Misses 17 4 -13 Continue to review full report at Codecov.
|
|
CI is all 🟢 ! |
See gazebo-tooling/release-tools#685