Skip to content

Fix pybind11 compilation on focal/clang12 combination#400

Merged
scpeters merged 5 commits intomainfrom
clang12
Apr 18, 2022
Merged

Fix pybind11 compilation on focal/clang12 combination#400
scpeters merged 5 commits intomainfrom
clang12

Conversation

@mjcarroll
Copy link
Copy Markdown

@mjcarroll mjcarroll commented Apr 1, 2022

Signed-off-by: Michael Carroll michael@openrobotics.org

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from scpeters as a code owner April 1, 2022 13:48
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 1, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2022

Codecov Report

Merging #400 (0a9c877) into main (ed2300a) will not change coverage.
The diff coverage is n/a.

❗ Current head 0a9c877 differs from pull request most recent head de356a5. Consider uploading reports for the commit de356a5 to get more accurate results

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          46       46           
  Lines        4260     4260           
=======================================
  Hits         4256     4256           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2300a...de356a5. Read the comment docs.

@mjcarroll mjcarroll self-assigned this Apr 1, 2022
@scpeters
Copy link
Copy Markdown
Member

scpeters commented Apr 1, 2022

CI failures on Jammy seem unrelated. I've ticketed them in #401, and I personally am suspicious of gazebosim/gz-cmake#218

@scpeters
Copy link
Copy Markdown
Member

there is an unrelated cmake warning that already exists on main:

-- Searching for Python - not found.
CMake Warning at /usr/share/cmake/ignition-cmake3/cmake3/IgnConfigureBuild.cmake:55 (message):
   CONFIGURATION WARNINGS:
   -- Python is missing: Python interfaces are disabled.
Call Stack (most recent call first):
  CMakeLists.txt:106 (ign_configure_build)

@scpeters scpeters merged commit fb741dd into main Apr 18, 2022
@scpeters scpeters deleted the clang12 branch April 18, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants