Skip to content

Added helper function to check if a string represents a time#389

Merged
chapulina merged 2 commits intoign-math6from
is_time_helper
Mar 25, 2022
Merged

Added helper function to check if a string represents a time#389
chapulina merged 2 commits intoign-math6from
is_time_helper

Conversation

@nkoenig
Copy link
Copy Markdown
Contributor

@nkoenig nkoenig commented Mar 16, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

This adds a helper function that checks if a string is a represents a time.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from scpeters as a code owner March 16, 2022 19:30
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Mar 16, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2022

Codecov Report

Merging #389 (489c491) into ign-math6 (3b3e7ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           ign-math6     #389   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6392   +12     
==========================================
+ Hits            6358     6370   +12     
  Misses            22       22           
Impacted Files Coverage Δ
include/ignition/math/Helpers.hh 98.71% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3e7ab...489c491. Read the comment docs.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@chapulina chapulina merged commit bfd45d0 into ign-math6 Mar 25, 2022
@chapulina chapulina deleted the is_time_helper branch March 25, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants