Conversation
added 2 commits
January 28, 2022 15:22
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 65 65
Lines 6101 6103 +2
=======================================
+ Hits 6079 6081 +2
Misses 22 22
Continue to review full report at Codecov.
|
azeey
reviewed
Jan 28, 2022
added 2 commits
January 30, 2022 10:13
Signed-off-by: Michael Carroll <michael@openrobotics.org>
ImplPtr makes this test irrelevant Signed-off-by: Michael Carroll <michael@openrobotics.org>
azeey
approved these changes
Feb 2, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncovered a few things during a clang-12 build.
The big one is that we weren't correctly forwarding arguments in
Quaternion::Axis, so I fixed it and added a test to prevent further regressions.Everything else was unused variables.