Skip to content

Added MassMatrix3 pybind11 interface#345

Merged
ahcorde merged 5 commits intoign-math6from
ahcorde/pybind11/massMatrix
Dec 28, 2021
Merged

Added MassMatrix3 pybind11 interface#345
ahcorde merged 5 commits intoign-math6from
ahcorde/pybind11/massMatrix

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Dec 28, 2021 •
edited
Loading

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

This PR creates a MassMatrix3 Pybind11 interface

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Added MassMatrix3 pybind11 interface
4e433ff 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters as a code owner December 28, 2021 18:53
@ahcorde ahcorde self-assigned this Dec 28, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Dec 28, 2021
@ahcorde
Fixed tests
b6e4133 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Merge branch 'ahcorde/pybind11/massMatrix' of https://github.com/igni…
715ec6f 
…tionrobotics/ign-math into ahcorde/pybind11/massMatrix
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 28, 2021 •
edited
Loading

Codecov Report

Merging #345 (608ebac) into ign-math6 (f564c74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #345   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6364     6364           
==========================================
  Hits            6342     6342           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f564c74...608ebac. Read the comment docs.

@ahcorde ahcorde requested a review from chapulina December 28, 2021 19:32
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Dec 28, 2021
@ahcorde ahcorde merged commit fc9fb78 into ign-math6 Dec 28, 2021
@ahcorde ahcorde deleted the ahcorde/pybind11/massMatrix branch December 28, 2021 20:54
@osrf-triage
Copy link
Copy Markdown

osrf-triage commented Mar 1, 2022

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahcorde ahcorde

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @osrf-triage @chapulina @j-rivero