Skip to content

Added Temperature pybind11 interface#330

Merged
ahcorde merged 8 commits intoign-math6from
ahcorde/pybind11/temperature
Dec 28, 2021
Merged

Added Temperature pybind11 interface#330
ahcorde merged 8 commits intoign-math6from
ahcorde/pybind11/temperature

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Dec 24, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

This PR creates a Temperature Pybind11 interface

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters as a code owner December 24, 2021 11:18
@ahcorde ahcorde self-assigned this Dec 24, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Dec 24, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2021

Codecov Report

Merging #330 (0253bed) into ign-math6 (c2ce7d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #330   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6364     6380   +16     
==========================================
+ Hits            6342     6358   +16     
  Misses            22       22           
Impacted Files Coverage Δ
include/ignition/math/Temperature.hh 100.00% <ø> (ø)
src/Temperature.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ce7d4...0253bed. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Dec 27, 2021
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

@ahcorde ahcorde merged commit 85224e3 into ign-math6 Dec 28, 2021
@ahcorde ahcorde deleted the ahcorde/pybind11/temperature branch December 28, 2021 22:55
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants