Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
8 tasks
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #313 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6360 6360
==========================================
Hits 6338 6338
Misses 22 22 Continue to review full report at Codecov.
|
mjcarroll
reviewed
Dec 23, 2021
Comment on lines
+35
to
+68
| /// \brief Compute sphere volume | ||
| /// \param[in] _radius Sphere radius | ||
| /// \return sphere volume | ||
| float SphereVolume(const float _radius) | ||
| { | ||
| return IGN_SPHERE_VOLUME(_radius); | ||
| } | ||
|
|
||
| /// \brief Compute cylinder volume | ||
| /// \param[in] _r Cylinder base radius | ||
| /// \param[in] _l Cylinder length | ||
| /// \return cylinder volume | ||
| float CylinderVolume(const float _r, const float _l) | ||
| { | ||
| return IGN_CYLINDER_VOLUME(_r, _l); | ||
| } | ||
|
|
||
| /// \brief Compute box volume | ||
| /// \param[in] _x X length | ||
| /// \param[in] _y Y length | ||
| /// \param[in] _z Z length | ||
| /// \return box volume | ||
| float BoxVolume(const float _x, const float _y, const float _z) | ||
| { | ||
| return IGN_BOX_VOLUME(_x, _y, _z); | ||
| } | ||
|
|
||
| /// \brief Compute box volume from a vector | ||
| /// \param[in] _v Vector3d that contains the box's dimensions. | ||
| /// \return box volume from a vector | ||
| float BoxVolumeV(const ignition::math::Vector3d &_v) | ||
| { | ||
| return IGN_BOX_VOLUME_V(_v); | ||
| } |
There was a problem hiding this comment.
I intend on replacing these macros with constexpr functions in main, just a thought when we are forward porting.
mjcarroll
approved these changes
Dec 23, 2021
8 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
This PR creates a Helpers Pybind11 interface
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.