Add example and modify document for class Color#304
Merged
ahcorde merged 4 commits intogazebosim:ign-math6from Dec 15, 2021
Merged
Add example and modify document for class Color#304ahcorde merged 4 commits intogazebosim:ign-math6from
ahcorde merged 4 commits intogazebosim:ign-math6from
Conversation
ahcorde
requested changes
Dec 11, 2021
Signed-off-by: youhy <haoyuan2019@outlook.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #304 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6359 6359
==========================================
Hits 6337 6337
Misses 22 22
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Dec 15, 2021
Contributor
|
Thank you for your contribution! |
45 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Document
Add an example for class Color as one goal mentioned in #300
Summary
Add an example for class Color and change the existing documents.
Test it
Others
I found something weird about the
ignition::math::Color::HSV()andignition::math::Color::SetFromHSV()when writing the example. When using the return value of theHSV()as the input forSetFromHSV(), the value of the instance is inconsistent. But I am not sure if it is a bug or I'm just using it the wrong way so I am not sure if making it a separate issue is a good idea.Like this (put it in /example)
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge