Skip to content

Evict large function definitions from the Helpers.hh header file#288

Merged
mjcarroll merged 1 commit intogazebosim:mainfrom
jwnimmer-tri:helpers-no-inline
Nov 23, 2021
Merged

Evict large function definitions from the Helpers.hh header file#288
mjcarroll merged 1 commit intogazebosim:mainfrom
jwnimmer-tri:helpers-no-inline

Conversation

@jwnimmer-tri
Copy link
Copy Markdown
Contributor

@jwnimmer-tri jwnimmer-tri commented Nov 23, 2021 •
edited
Loading

🦟 Bug fix

Summary

Evict large function definitions from the Helpers.hh header file, per Google Style Guide.

This is a prerequistite for fixing the static storage duration of the std::regex used by the duration parser, towards the goal of #269.

Checklist

  • Signed all commits for DCO
  • Added tests (N/A)
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing) -- no new errors; the 9 errors on the main branch are also reported on this PR.
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jwnimmer-tri
Copy link
Copy Markdown
Contributor Author

jwnimmer-tri commented Nov 23, 2021

In other projects, sometimes when I move code from hh to cc files, I'll add Co-authored-by lines to the commit message to reflect the original (header file) authorship of the moved lines back into the cc file. Let me know if you'd like me to do that here.

ahcorde
ahcorde previously requested changes Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows is not happy https://build.osrfoundation.org/job/ignition_math-ci-pr_any-windows7-amd64/1332/consoleFull#-19329938068ff58640-3599-4406-a210-216932f1748c

@jwnimmer-tri
Evict large function definitions from the Helpers.hh header file
d080c06 
Signed-off-by: Jeremy Nimmer <jeremy.nimmer@tri.global>
@jwnimmer-tri
Copy link
Copy Markdown
Contributor Author

jwnimmer-tri commented Nov 23, 2021

Windows is fixed as of the latest push. I'd missed the IGNITION_MATH_VISIBLE the first time around.

@mjcarroll
Copy link
Copy Markdown

mjcarroll commented Nov 23, 2021

Let me know if you'd like me to do that here.

I don't think it's necessary here.

@mjcarroll mjcarroll enabled auto-merge (squash) November 23, 2021 20:40
@mjcarroll mjcarroll dismissed ahcorde’s stale review November 23, 2021 20:40

windows ci is fixed

@mjcarroll mjcarroll merged commit 797f67f into gazebosim:main Nov 23, 2021
@jwnimmer-tri jwnimmer-tri deleted the helpers-no-inline branch November 23, 2021 20:40
@jwnimmer-tri jwnimmer-tri mentioned this pull request Nov 23, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde left review comments

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jwnimmer-tri @mjcarroll @ahcorde @j-rivero @osrf-triage