Fix windows warnings in Vector2, 3 and 4#284
Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #284 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6359 6359
==========================================
Hits 6337 6337
Misses 22 22
Continue to review full report at Codecov.
|
7 tasks
jwnimmer-tri
suggested changes
Nov 23, 2021
Contributor
jwnimmer-tri
left a comment
There was a problem hiding this comment.
FYI I'm not a project maintainer, just trying to do my part and review other PRs as requested in the template for the PRs that I have submitted.
Signed-off-by: ahcorde <ahcorde@gmail.com>
jwnimmer-tri
approved these changes
Nov 25, 2021
chapulina
approved these changes
Nov 29, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Warnings
Summary
Fix windows warnings in Vector2, 3 and 4
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge