Internal URL fixed (paragraph 266)#279
Conversation
chapulina
left a comment
There was a problem hiding this comment.
Nice catch, thanks! Can you sign your commit for the DCO checker?
Codecov Report
@@ Coverage Diff @@
## ign-math6 #279 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6374 6374
==========================================
Hits 6337 6337
Misses 37 37 Continue to review full report at Codecov.
|
|
friendly ping @kant |
47abc81 to
2e8faa7
Compare
|
@kant the DCO is still failing. You can try this: git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1 |
After the last script Appended to original pull request according https://ignitionrobotics.org/docs/all/contributing#process |
|
@kant , did you fetch your repo and checkout the right branch? git clone https://github.com/kant/ign-math
cd ign-math
git checkout patch-1
git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1 |
|
@kant, did you try the last suggestion? |
Signed-off-by: Darío Hereñú <magallania@gmail.com>
|
Done! (following this procedures: |
|
Thanks again, @kant ! |
|
Thanks for sharing your knowledge. It is a pleasure to contribute to this project. Kudos and thanks for your patience @ahcorde @chapulina @scpeters @clalancette !! |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🦟 Bug fix
No Fixes any previous PR
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
Signed-off-by: Darío Hereñú magallania@gmail.com