Skip to content

OrientedBox Python interface#276

Merged
scpeters merged 7 commits intoign-math6from
ahcorde/python/orientedbox
Nov 9, 2021
Merged

OrientedBox Python interface#276
scpeters merged 7 commits intoign-math6from
ahcorde/python/orientedbox

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Oct 29, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added OrientedBox Python interface.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters October 29, 2021 09:52
@ahcorde ahcorde self-assigned this Oct 29, 2021
@github-actions github-actions Bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 29, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2021

Codecov Report

Merging #276 (d4ce73c) into ign-math6 (f92b793) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #276   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92b793...d4ce73c. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 29, 2021
@scpeters scpeters changed the title Added OrientedBox Python interface OrientedBox Python interface Nov 8, 2021
Comment thread src/python/OrientedBox_TEST.py Outdated
box = OrientedBoxd(Vector3d(0.1, -2.1, 0.0))
self.assertEqual(box.xlength(), 0.1)
self.assertEqual(box.ylength(), 2.1)
self.assertEqual(box.zlength(), 0.0)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've already merged support for AxisAlignedBox with XLength() in c++ mapped to xlength() in python (and simlar for y, z), but I think it would look nicer as x_length, y_length and z_length. Is there an easy way to do that?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see that we've done that for Quaternion and PID already with %rename(), so I'll add that here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar change for AxisAlignedBox in #281

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters merged commit cbc2a1b into ign-math6 Nov 9, 2021
@scpeters scpeters deleted the ahcorde/python/orientedbox branch November 9, 2021 04:19
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants