Skip to content

Inertial Python interface#275

Merged
scpeters merged 5 commits intoign-math6from
ahcorde/python/inertial
Nov 8, 2021
Merged

Inertial Python interface#275
scpeters merged 5 commits intoign-math6from
ahcorde/python/inertial

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Oct 29, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added Inertial Python interface.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters October 29, 2021 09:46
@ahcorde ahcorde self-assigned this Oct 29, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 29, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2021

Codecov Report

Merging #275 (60ceeea) into ign-math6 (074aa53) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #275   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074aa53...60ceeea. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 29, 2021
@scpeters scpeters changed the title Added Inertial Python interface Inertial Python interface Oct 30, 2021
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
In c++ the test object is recreated in different scopes,
but it was being reused in the python test and accumulating
error.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member

scpeters commented Nov 8, 2021

there were a few parts of the test commented out, so I've fixed the issues and enabled them

  • scalar multiplication with a Vector3d only seems to work on the right side (Vector3d(1, 2, 3) * 0.5 is ok, but 0.5 * Vector3d(1, 2, 3) doesn't work)
  • there was an object being reused in the test that was accumulating error, but it was fixed once I created a fresh copy of the object

@scpeters scpeters merged commit a4d0b1f into ign-math6 Nov 8, 2021
@scpeters scpeters deleted the ahcorde/python/inertial branch November 8, 2021 21:49
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants