Skip to content

DiffDriveOdometry Python interface#265

Merged
scpeters merged 7 commits intoign-math6from
ahcorde/python/diffdrive
Nov 1, 2021
Merged

DiffDriveOdometry Python interface#265
scpeters merged 7 commits intoign-math6from
ahcorde/python/diffdrive

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Oct 11, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added DiffDriveOdometry Python interface.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested review from azeey and scpeters October 11, 2021 14:20
@ahcorde ahcorde self-assigned this Oct 11, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 11, 2021
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 11, 2021
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Oct 12, 2021

It seems that Bionic and Focal are using a different version of SWIG, and the %typemap(in, numinputs=1) should be diferrent. Looking in to it.

@scpeters
Copy link
Copy Markdown
Member

I merged #266 and then merged this with the base branch and now there are ubuntu compilation errors

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2021

Codecov Report

Merging #265 (2d79ebc) into ign-math6 (c732c04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #265   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c732c04...2d79ebc. Read the comment docs.

@ahcorde ahcorde requested a review from scpeters October 29, 2021 11:21
@scpeters scpeters changed the title Added DiffDriveOdometry Python interface DiffDriveOdometry Python interface Oct 29, 2021
}
using std::chrono::duration_cast;
$1 = new std::chrono::steady_clock::time_point();
*$1 += duration_cast<std::chrono::steady_clock::duration>(std::chrono::milliseconds(PyInt_AsLong($input)));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to read a bit more to understand this swig syntax

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scpeters scpeters merged commit 2f88723 into ign-math6 Nov 1, 2021
@scpeters scpeters deleted the ahcorde/python/diffdrive branch November 1, 2021 21:52
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants