Skip to content

MassMatrix3 Python interface#260

Merged
scpeters merged 4 commits intoign-math6from
ahcorde/python/massmatrix
Oct 22, 2021
Merged

MassMatrix3 Python interface#260
scpeters merged 4 commits intoign-math6from
ahcorde/python/massmatrix

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Oct 11, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added MassMatrix3 Python interface.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Added MassMatrix3 Python interface
d75edf6 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested review from azeey and scpeters October 11, 2021 13:24
@ahcorde ahcorde self-assigned this Oct 11, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 11, 2021
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Oct 11, 2021

it Requires #251

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 11, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #260 (ece3c29) into ign-math6 (000ab21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #260   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000ab21...ece3c29. Read the comment docs.

scpeters
scpeters previously approved these changes Oct 22, 2021
View reviewed changes
@scpeters scpeters changed the title Added MassMatrix3 Python interface MassMatrix3 Python interface Oct 22, 2021
@scpeters scpeters dismissed their stale review October 22, 2021 21:35

approved the wrong PR

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Oct 22, 2021

approved the wrong PR

Is there something wrong here ?

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Oct 22, 2021

approved the wrong PR

Is there something wrong here ?

no I just haven't reviewed it yet

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Oct 22, 2021

it looks like some of the C++ test comments are out of date, but I won't block on that

@scpeters scpeters merged commit c732c04 into ign-math6 Oct 22, 2021
@scpeters scpeters deleted the ahcorde/python/massmatrix branch October 22, 2021 23:56
@ahcorde ahcorde mentioned this pull request Oct 29, 2021
Closed
45 tasks
@osrf-triage
Copy link
Copy Markdown

osrf-triage commented Mar 1, 2022

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

@azeey azeey Awaiting requested review from azeey

Assignees

@ahcorde ahcorde

Labels

🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahcorde @scpeters @osrf-triage @j-rivero @chapulina