Skip to content

Add Python interface to Triangle3#247

Merged
scpeters merged 8 commits intoign-math6from
ahcorde/python/triangle
Oct 8, 2021
Merged

Add Python interface to Triangle3#247
scpeters merged 8 commits intoign-math6from
ahcorde/python/triangle

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Sep 22, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Adds Python interface for Triangle3.

Related to #101 #210

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 22, 2021
@ahcorde ahcorde requested a review from scpeters as a code owner September 22, 2021 21:56
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 22, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 22, 2021

Codecov Report

Merging #247 (80baf10) into ign-math6 (f93eeea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #247   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6347     6351    +4     
==========================================
+ Hits            6310     6314    +4     
  Misses            37       37           
Impacted Files Coverage Δ
include/ignition/math/Triangle3.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93eeea...80baf10. Read the comment docs.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Sep 24, 2021
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Oct 8, 2021

friendly ping @scpeters

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters October 8, 2021 20:59
@scpeters scpeters merged commit 564c52e into ign-math6 Oct 8, 2021
@scpeters scpeters deleted the ahcorde/python/triangle branch October 8, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants