Skip to content

Adds python interface to triangle.#231

Merged
chapulina merged 8 commits intoign-math6from
LolaSegura/add_triangle
Aug 31, 2021
Merged

Adds python interface to triangle.#231
chapulina merged 8 commits intoign-math6from
LolaSegura/add_triangle

Conversation

@LolaSegura
Copy link
Copy Markdown
Contributor

@LolaSegura LolaSegura commented Aug 30, 2021 •
edited by francocipollone
Loading

🎉 New feature

Goes on top of #220
Related to #101 #210

Summary

Adds Python interface for Triangle.

Related issues and notes

  • To offer the operator[] functionality in python, the class had to be extended in the interface file (.i file) adding getitem(), calling the operator[] inside.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

WagnerMarcos and others added 6 commits August 24, 2021 11:42
@WagnerMarcos
Adds Line2, SignalStats, Temperature python interface
c97f3e4 
Signed-off-by: Marcos Wagner <wagnermarcos@ekumenlabs.com>
@WagnerMarcos
Adding Line3 class with its test
3fefff8 
Signed-off-by: Marcos Wagner <wagnermarcos@ekumenlabs.com>
@WagnerMarcos
Adding %rename tag to interface files to match PEP8
31be8f8 
Signed-off-by: Marcos Wagner <wagnermarcos@ekumenlabs.com>
@WagnerMarcos
Applying alphasort to include and snake_case to variables
34be3d6 
Signed-off-by: Marcos Wagner <wagnermarcos@ekumenlabs.com>
@WagnerMarcos
Fixing a typo and trailing spaces
8536f32 
Signed-off-by: Marcos Wagner <wagnermarcos@ekumenlabs.com>
@LolaSegura
Adds a python interface to Triangle.
52f1b15 
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Merging #231 (5bca988) into ign-math6 (3ea6229) will not change coverage.
The diff coverage is n/a.

❗ Current head 5bca988 differs from pull request most recent head d1fbba1. Consider uploading reports for the commit d1fbba1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #231   +/-   ##
==========================================
  Coverage      99.21%   99.21%           
==========================================
  Files             65       65           
  Lines           6089     6089           
==========================================
  Hits            6041     6041           
  Misses            48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea6229...d1fbba1. Read the comment docs.

@francocipollone francocipollone mentioned this pull request Aug 30, 2021
Closed
45 tasks
@francocipollone
Copy link
Copy Markdown
Contributor

francocipollone commented Aug 31, 2021 •
edited
Loading

Update this branch now that #220 got merged --> Done

@francocipollone
Merge branch 'ign-math6' into LolaSegura/add_triangle
50f26f2 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Copy link
Copy Markdown
Contributor

francocipollone commented Aug 31, 2021

I've just fixed conflicts.

@francocipollone
nit: sort import statement.
d1fbba1 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone marked this pull request as ready for review August 31, 2021 17:17
chapulina
chapulina approved these changes Aug 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chapulina chapulina merged commit 3eae090 into ign-math6 Aug 31, 2021
@chapulina chapulina deleted the LolaSegura/add_triangle branch August 31, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

2 more reviewers

@chapulina chapulina chapulina approved these changes

@francocipollone francocipollone francocipollone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LolaSegura @francocipollone @chapulina @j-rivero @osrf-triage @WagnerMarcos