Skip to content

Master branch updates#195

Merged
chapulina merged 1 commit intoign-math6from
chapulina/bye_master
Mar 10, 2021
Merged

Master branch updates#195
chapulina merged 1 commit intoign-math6from
chapulina/bye_master

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

@chapulina chapulina commented Mar 8, 2021

Part of gazebo-tooling/release-tools#416

Summary

Update all usage of master

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@chapulina
Master branch updates
43fefdb 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters as a code owner March 8, 2021 22:47
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Mar 8, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2021 •
edited
Loading

Codecov Report

Merging #195 (43fefdb) into ign-math6 (7faac05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #195   +/-   ##
==========================================
  Coverage      99.20%   99.20%           
==========================================
  Files             63       63           
  Lines           6020     6020           
==========================================
  Hits            5972     5972           
  Misses            48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7faac05...43fefdb. Read the comment docs.

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Mar 9, 2021

@osrf-jenkins run tests please

@chapulina chapulina enabled auto-merge (squash) March 9, 2021 18:10
@adlarkin adlarkin self-requested a review March 10, 2021 19:58
adlarkin
adlarkin approved these changes Mar 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick repository search (thanks git grep), and noticed that the link here no longer works. I believe it should be:

https://github.com/RobotLocomotion/drake/blob/master/multibody/tree/rotational_inertia.h

Should we make that change here before merging?

@chapulina chapulina merged commit 19f9372 into ign-math6 Mar 10, 2021
@chapulina chapulina deleted the chapulina/bye_master branch March 10, 2021 20:05
@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Mar 10, 2021

Should we make that change here before merging?

Oops, auto-merge didn't give us a chance. Feel free to open a new PR with that change. Unfortunately, links tend to deteriorate over time 😕

@adlarkin adlarkin mentioned this pull request Mar 10, 2021
Merged
7 tasks
@adlarkin
Copy link
Copy Markdown
Contributor

adlarkin commented Mar 10, 2021

Oops, auto-merge didn't give us a chance. Feel free to open a new PR with that change. Unfortunately, links tend to deteriorate over time

No worries, I forgot that we picked auto-merge here. Here's a PR with the change: #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

1 more reviewer

@adlarkin adlarkin adlarkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @scpeters @adlarkin @j-rivero @osrf-triage