Skip to content

Bazel Updates for math6#171

Merged
mjcarroll merged 17 commits intoign-math6from
bazel-math6
Mar 16, 2021
Merged

Bazel Updates for math6#171
mjcarroll merged 17 commits intoign-math6from
bazel-math6

Conversation

@mjcarroll
Copy link
Copy Markdown

@mjcarroll mjcarroll commented Oct 23, 2020

Rebase the bazel branch to be off of math6, the version used in dome.

Specific cleanups and feedback incorporated in 18b35a0

This will replace the current bazel branch.

Michael Carroll and others added 6 commits October 20, 2020 14:45
Bazel build rules for math
aa0489d 
Co-authored-by: John Shepherd <john@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Rename eigen dep to eigen3 for consistency (#127)
f6dd5b8 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
[Bazel] Fix sonames
bd8e3da 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Add apt packages list
419bd81 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
add ign export
26d3f98 
Signed-off-by: John Shepherd <john@openrobotics.org>
Incorporate feedback and cleanups
18b35a0 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 23, 2020
@mjcarroll mjcarroll mentioned this pull request Oct 23, 2020
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #171 (90cbf4b) into ign-math6 (1e9ce65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #171   +/-   ##
==========================================
  Coverage      99.20%   99.20%           
==========================================
  Files             63       63           
  Lines           6019     6019           
==========================================
  Hits            5971     5971           
  Misses            48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e9ce65...5794ee7. Read the comment docs.

mahiuchun
mahiuchun reviewed Nov 18, 2020
View reviewed changes
mahiuchun
mahiuchun reviewed Nov 18, 2020
View reviewed changes
@JShep1 JShep1 self-requested a review November 25, 2020 01:16
JShep1
JShep1 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine with all tests passing for bazel and colcon

chapulina
chapulina reviewed Nov 25, 2020
View reviewed changes
@mjcarroll mjcarroll marked this pull request as ready for review December 1, 2020 21:37
@mjcarroll mjcarroll requested a review from scpeters as a code owner December 1, 2020 21:37
Michael Carroll and others added 4 commits December 1, 2020 15:38
Address reviewer feedback
e7a37b4 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Remove packages.apt file
25b7595 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Merge branch 'ign-math6' into bazel-math6
4eee54b
add capsule
6ca2c9d 
Signed-off-by: John Shepherd <john@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member

scpeters commented Dec 2, 2020

are we going to setup CI for bazel to prevent regressions?

@JShep1
Copy link
Copy Markdown

JShep1 commented Dec 2, 2020

Just added the Capsule class. This brings up a good point, perhaps we eventually want to glob for files? We're globbing for tests so it will automatically break CI if someone adds new files and tests for them since the bazel build files will pick up the new tests but not the new files.

Michael Carroll added 4 commits February 16, 2021 11:32
Merge branch 'ign-math6' into bazel-math6
b516968
Updates for upstream
7d8d3c4 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Merge branch 'ign-math6' into bazel-math6
0ecda4d
Buildifier
8e52c1a 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Michael Carroll added 2 commits March 16, 2021 12:15
Merge branch 'ign-math6' into bazel-math6
784c5d9
Bump version
5794ee7 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
chapulina
chapulina approved these changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Bazel, but I didn't notice anything weird, and CI that's using this branch seems to be happy with ign-math:

https://github.com/ignitionrobotics/ign-bazel/runs/2068842483?check_suite_focus=true

The branch for that build is configured here:

https://github.com/ignitionrobotics/ign-bazel/blob/6c7128cb4833bbbb06d397f785c61d02d7f8b962/.github/ci/bazel.repos#L5

@mjcarroll mjcarroll merged commit b84710d into ign-math6 Mar 16, 2021
@mjcarroll mjcarroll deleted the bazel-math6 branch March 16, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

3 more reviewers

@mahiuchun mahiuchun mahiuchun left review comments

@chapulina chapulina chapulina approved these changes

@JShep1 JShep1 JShep1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mjcarroll @scpeters @JShep1 @mahiuchun @chapulina @j-rivero @osrf-triage