Create Round(), Rounded() functions for Vector2.hh#166
Merged
chapulina merged 1 commit intogazebosim:ign-math6from Oct 17, 2020
Merged
Create Round(), Rounded() functions for Vector2.hh#166chapulina merged 1 commit intogazebosim:ign-math6from
chapulina merged 1 commit intogazebosim:ign-math6from
Conversation
- Round(): Rounds to nearest whole number inplace - Rounded(): Returns a rounded version of the vector Created unit tests for both functions. colcon build --merge-install [PASSED] colcon test --merge-install [PASSED] Intend to solve issue ignitionrobotics#71 Signed-off-by: akshatpandya <akspandya.97@gmail.com>
2e7b67e to
ed89d37
Compare
chapulina
approved these changes
Oct 17, 2020
Contributor
chapulina
left a comment
There was a problem hiding this comment.
Thank you for the contribution, @akshatpandya !
This looks good to me. I'll just wait for all tests to finish running before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created unit tests for both functions.
colcon build --merge-install [PASSED]
colcon test --merge-install [PASSED]
Intend to solve issue ignitionrobotics#71
Signed-off by: Akshat Pandya akspandya.97@gmail.com