Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
…gnitionrobotics/ign-math into jshep1/string_to_chrono_helper Signed-off-by: John Shepherd <john@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #152 +/- ##
=============================================
- Coverage 99.24% 99.23% -0.02%
=============================================
Files 59 59
Lines 5823 5867 +44
=============================================
+ Hits 5779 5822 +43
- Misses 44 45 +1
Continue to review full report at Codecov.
|
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…nitionrobotics/ign-math into ahcorde/time/helper_functions
ahcorde
left a comment
There was a problem hiding this comment.
Just a comment about try/catch
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Cast to system_clock::duration where necessary. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
left a comment
There was a problem hiding this comment.
Signed-off-by: ahcorde <ahcorde@gmail.com>
…nitionrobotics/ign-math into ahcorde/time/helper_functions
Signed-off-by: John Shepherd <john@openrobotics.org>
…rono_helper Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…rono_helper Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
|
Not sure why codecov is marking some lines as uncovered, when they clearly are: |
I was also wondering this |
|
sdformat is building |
| const std::string &_timeString) | ||
| { | ||
| std::chrono::steady_clock::time_point timePoint = | ||
| math::secNsecToTimePoint(-1, 0); |
There was a problem hiding this comment.
I'm seeing an msbuild warning when compiling this from source for sdformat:
'argument': conversion from 'int' to 'const uint64_t', signed/unsigned mismatch
There was a problem hiding this comment.
I'm guessing it's complaining about the implicit cast of -1 to const uint64_t
There was a problem hiding this comment.
Yes, I just realized this, I guess an invalid string will have to return 0 now, I was using -1 as an indication of error, but now it seems that's not going to be possible
| { | ||
| numberDays = std::stoi(dayString); | ||
| } | ||
| catch (const std::out_of_range &oor) |
There was a problem hiding this comment.
another windows warning found by sdformat:
'oor': unreferenced local variable
There was a problem hiding this comment.
I think this would be easy enough to fix by just deleting oor:
catch (const std::out_of_range &)
There was a problem hiding this comment.
Thanks for pointing this out, I'm creating a PR now
Adds a function converting a string of the general format "dd hh:mm:ss.nnn" where n is millisecond values to a
std::chrono::steady_clock::time_pointDepends on #150
Signed-off-by: John Shepherd john@openrobotics.org