Merged
Conversation
Signed-off-by: Lucas Fernando <lucas.costa@ee.ufcg.edu.br>
chapulina
approved these changes
Aug 1, 2020
Contributor
chapulina
left a comment
There was a problem hiding this comment.
Thanks for the docs, they are very clear and should help a lot of people (including me, I didn't know how to run the tests separately!).
I left some small suggestions for your consideration.
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Contributor
Author
|
Thanks for the suggestions! I'm getting into the use of |
Contributor
No worries. One annoying thing when using the GitHub UI to accept suggestions is that they're not signed by default. You need to add the signature on the UI yourself, which is inconvenient 😕 That's why the DCO check failed... But don't worry this time, I'll make sure the commit is signed when squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #136 .
Add install prerequisites and testing subsection Ruby Tests.
Tried to do an guide for absolute beginners, on how to create an interface and use this in a test file, using
Swigdocumentation important points as reference.