Sum normalized functions#140
Merged
chapulina merged 6 commits intogazebosim:ign-math6from Aug 1, 2020
Merged
Conversation
Signed-off-by: Lucas Fernando <lucas.costa@ee.ufcg.edu.br>
Signed-off-by: Lucas Fernando <lucas.costa@ee.ufcg.edu.br>
mjcarroll
requested changes
Jul 27, 2020
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM, but there are some conflicts to resolve before it can land.
Contributor
Author
|
@mjcarroll conflict resolved. |
mjcarroll
approved these changes
Jul 29, 2020
|
Failing Bionic CI is currently expected because of ongoing infrastructure improvements. |
Contributor
Author
|
@mjcarroll is normal that |
Not necessarily "normal", but you can check the build queue at build.osrfoundation.org, you can see that it is a bit backed up at the moment. |
chapulina
reviewed
Jul 31, 2020
Signed-off-by: Lucas Fernando <lucas.costa@ee.ufcg.edu.br>
chapulina
approved these changes
Aug 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #71 .
This implements the functions Sum() and Normalized() in Vector4 API.
It enables: