Skip to content

Add Abs, Dot and AbsDot and respective tests to Vector4#135

Merged
mjcarroll merged 3 commits intogazebosim:ign-math6from
luccosta:abs-absdot-dot-functions
Jul 27, 2020
Merged

Add Abs, Dot and AbsDot and respective tests to Vector4#135
mjcarroll merged 3 commits intogazebosim:ign-math6from
luccosta:abs-absdot-dot-functions

Conversation

@luccosta
Copy link
Copy Markdown
Contributor

@luccosta luccosta commented Jul 15, 2020

Resolves #71 .

This implements the functions Abs(), Dot(Vector4) and AbsDot(Vector4) in Vector4 API, similar to the existing same functions in Vector3.

It enables Vector4 objects to perform:

vec4.Abs();
vec4_a.Dot(vec4_b);
vec4_a.AbsDot(vec4_b);

Did all checks and tests.

@luccosta
Add Abs, Dot and AbsDot and respective tests to Vector4
04d9588 
Signed-off-by: Lucas Fernando <lucas.costa@ee.ufcg.edu.br>
@luccosta luccosta requested a review from scpeters as a code owner July 15, 2020 23:55
@chapulina chapulina added enhancement New feature or request 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jul 16, 2020
mjcarroll
mjcarroll reviewed Jul 17, 2020
View reviewed changes
luccosta and others added 2 commits July 17, 2020 21:33
@luccosta luccosta force-pushed the abs-absdot-dot-functions branch from 1d26e5f to f9b3ea2 Compare July 22, 2020 23:39
@luccosta
Copy link
Copy Markdown
Contributor Author

luccosta commented Jul 22, 2020 •
edited
Loading

After merge ign-math6 backwards, locally everything is running ok, but the Ubuntu Bionic CI is getting:

Unexpected input(s) 'script-after-make', valid inputs are ['entryPoint', 'args', 'github_token', 'apt-dependencies', 'codecov-token', 'cmake-args']

And I'm not finding anything about this.

Same happening on ruby PR #137 .

@chapulina
Copy link
Copy Markdown
Contributor

chapulina commented Jul 23, 2020

Unexpected input(s) 'script-after-make'

Don't worry, you can ignore this. It's a problem with our infrastructure.

@luccosta luccosta requested a review from mjcarroll July 23, 2020 22:31
@mjcarroll mjcarroll merged commit d50d094 into gazebosim:ign-math6 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luccosta @chapulina @mjcarroll @j-rivero