Add include <chrono> for system_clock#655
Merged
iche033 merged 2 commits intogazebosim:gz-common5from Dec 17, 2024
WangWeiLin-MV:events/add-include-chrono
Merged
Add include <chrono> for system_clock#655iche033 merged 2 commits intogazebosim:gz-common5from WangWeiLin-MV:events/add-include-chrono
iche033 merged 2 commits intogazebosim:gz-common5from
WangWeiLin-MV:events/add-include-chrono
Conversation
Signed-off-by: WangWeiLin-MV <156736127+WangWeiLin-MV@users.noreply.github.com>
7 tasks
ahcorde
approved these changes
Dec 12, 2024
Contributor
|
The PR is still a draft, do you more changes to include ? otherwise you can change the status to "Ready fo review". change looks good to me |
iche033
approved these changes
Dec 13, 2024
Contributor
|
@osrf-jenkins run tests please |
This was referenced Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
No bug number.
Summary
An issue revealed in microsoft/STL#5105, that can be fixed by including
<chrono>.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸