Build examples using native CMake#301
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
…bosim/gz-cmake into mjcarroll/examples_from_cmake
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
| # Optional. List of components built by this project that are used in the examples. | ||
| # For example "cli" for gz-utils | ||
| # | ||
| # DEPENDENCIES: |
There was a problem hiding this comment.
Let me see if I understand this right: in DEPENDENCIES you can specify gz- libraries that are not being used by the build system of the project but are required to make the examples to build/run? Is this correct? If so, bellow there is a comment:
we are passing in the resolved dependency directories via -Ddep_DIR=${dep_DIR}
How does this work if a dependency is not in the current buildsystem?
There was a problem hiding this comment.
I have a slight rework to this I can push shortly that drops this gymnastics a bit.
Note that this is only necessary for gazebo packages, as they may be built in the same workspace, so this special forwarding happens.
Currently, examples aren't allowed to depend on Gazebo packages things that the containing package doesn't. E.g. gz-gui examples cannot have a dependency on gz-gazebo, as this will introduce circular dependencies.
If an example depends on a non-Gazebo package, then typical find_package infrastructure should work.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
azeey
left a comment
There was a problem hiding this comment.
I finally got around to reviewing this. Sorry for the long delay.
My main issue is that we're adding all the resolved dependency directories when it doesn't seem necessary. Maybe something is misconfigured in my local system and there's a real need to do this.
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
🦟 Bug fix
Fixes (for the most part) Windows examples_build and deduplicates some build steps
Summary
When testing on the newest conda/Visual Studio 2022/Windows 11 configuration I ran into some issues with the "FAKE_INSTALL" step that we were doing in many packages, which was seen to be invalid. I was able to reproduce on Linux by trying to use the "ninja" generator for CMake.
After some investigation, I found that FAKE_INSTALL was actually causing the packages to be built twice, which adds significant overhead to the build.
This is an alternative mechanism for building examples as part of the test suite. Any package that wants to build examples will have to be updated to take advantage of this macro.
This is a pure CMake implementation that doesn't rely on calling out to other scripts/executables.
Downstream PRs:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.