Fix Content-Range response header for EncryptedBlobStore range requests#921
Merged
gaul merged 2 commits intogaul:masterfrom Nov 4, 2025
Conversation
Owner
|
Thank you for your contribution @polarctos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For HTTP requests with a
Rangeheader, it is generally expected to have aContent-Rangeresponse header.Some clients rely on this response header being present, but the
EncryptedBlobStore.javaimplementation did not add this header to the response.Especially the peculiar range request
Range: bytes=0-0is used by some clients to determine the full length of the object.A
HEADrequest would be more appropriate in this case, but nevertheless clients like this exist. E.g. the GitLab pages app.The expected response header in this case is then in the format
Content-Range: bytes 0-0/<size>.To fix this, this PR adds the
Content-Rangeheader to the response if the request included aRangeheader.Test were adapted to verify the header and also for the specific "double zero" range request for the
EncryptedBlobStore.