Add prefix middleware for bucket scoped storage#907
Merged
gaul merged 2 commits intogaul:masterfrom Nov 7, 2025
forwardnetworks:prefix-middleware
Merged
Add prefix middleware for bucket scoped storage#907gaul merged 2 commits intogaul:masterfrom forwardnetworks:prefix-middleware
gaul merged 2 commits intogaul:masterfrom
forwardnetworks:prefix-middleware
Conversation
gaul
approved these changes
Nov 6, 2025
| } | ||
|
|
||
| if (!Strings.isNullOrEmpty(requestedMarker)) { | ||
| effective.afterMarker(addPrefix(container, requestedMarker)); |
Owner
There was a problem hiding this comment.
This won't work for storage backends with opaque markers. I think it would probably be better to do:
if (Quirks.OPAQUE_MARKERS.contains(blobStoreType)) {
throw new UnsupportedOperationException("Only supports opaque markers");
}
Contributor
Author
There was a problem hiding this comment.
Middleware now rejects opaque-marker providers as suggested. Let me know if anything else is needed.
Owner
|
Thank you for your contribution @captainpacket! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrefixBlobStoremiddleware that scopes virtual buckets to a fixed backend prefixs3proxy.prefix-blobstore.*always use the new middlewareTesting