Implement atomic conditional puts for azureblob-sdk#902
Merged
gaul merged 2 commits intogaul:masterfrom Oct 13, 2025
Merged
Conversation
gaul
approved these changes
Oct 12, 2025
Contributor
Author
|
I addressed the comments and added fixups for proper method chaining in PutOptions2. |
Owner
|
Thank you for your contribution @klaudworks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements atomic conditional put operations for the azureblob-sdk provider as discussed in #894 (comment).
I kept the non-conditional put logic for all other providers. Whether we return 501 Not Implemented or do a non-conditional put, it both requires checking the Blobstore Type in the S3ProxyHandler and adding conditional logic.