Force Jetty header cache to be case-sensitive, to avoid signature mismatch#837
Merged
gaul merged 1 commit intogaul:masterfrom Jul 16, 2025
Merged
Conversation
…match (e.g. upper case charset used in S3Proxy, but lowercase used in original signature calculation)
Owner
|
Thank you for your contribution @re1709! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetty's header cache sometimes results in headers (and their values) being changed from what is sent in the request due to it's case insensitive nature.
This breaks AWS V2 and V4 signature calculations, as the sender will have calculated the signature with slightly different values.
E.g.
Forcing the cache to be case sensitive fixes this. Looks like this was an issue in the past, and was fixed by using the LEGACY validation option. However seems to now require this additional setting, which might be caused by the upgrade to Jetty 11?
(Jetty 12 has further work on this, so might need reviewing if/when that upgrade happens).