Conversation
This was referenced Oct 8, 2024
Owner
Author
|
Does single-character replacement suffice? Or would something more involved like regexes address more use cases? |
|
Could be another option. For example, |
Owner
Author
|
Do you have a specific use case for more complicated replacements? I won't add technical complexity just for fun. |
|
I'm happy with a straightforward string match and replacement. |
This is useful when keys and values must conform to some subset of values, e.g., Azure's C# identifiers. Fixes #466.
88f0d9d to
338a40a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when keys and values must conform to some subset of values, e.g., Azure's C# identifiers. Fixes #466.