Review: fix: repair nightly test failures for TestInitCancel_E2E and dolt autostart

Verdict: Clean, correct fix for two independent test failures. Ship it.

4 files, +27 −4. 1 commit. Two fixes: BD_NON_INTERACTIVE=0 override support (init.go, init_cancel_e2e_test.go, init_noninteractive_test.go) and --server flag for autostart lifecycle test (dolt_autostart_lifecycle_integration_test.go).

Fix 1: BD_NON_INTERACTIVE=0/false forces interactive mode

Root cause is clear. Commit 5e60961 added isNonInteractiveInit() which detects CI environments. TestInitCancel_E2E runs with --contributor, which line 119 rejects in non-interactive mode: FatalError("--contributor requires interactive prompts and cannot be used with --non-interactive"). The test never reaches the prompt it's waiting for.

The fix is correct and clean. The new logic:

if v := os.Getenv("BD_NON_INTERACTIVE"); v != "" {
    if v == "1" || v == "true" { return true }
    return false  // explicit opt-in to interactive
}

BD_NON_INTERACTIVE=0 enters the block (non-empty), doesn't match "1" or "true", and returns false — bypassing both CI detection and terminal detection. This is the right behavior: an explicit env var should take full precedence over heuristics.

Test env setup is thorough. The e2e test:

1. Adds BD_NON_INTERACTIVE and CI to the filteredEnv strip list (removes any inherited values)
2. Sets BD_NON_INTERACTIVE=0 (explicit interactive mode)
3. Sets CI= (empty string, disables CI detection as a belt-and-suspenders measure)

Step 3 is technically redundant since BD_NON_INTERACTIVE=0 short-circuits before CI is checked, but it's good defensive practice — if the precedence logic ever changes, the test still works.

Unit tests cover both 0 and false variants with CI=true set, confirming the override works even when CI would otherwise trigger non-interactive mode. ✅

🟡 Minor: unrecognized values silently force interactive mode

With the new logic, BD_NON_INTERACTIVE=yes or BD_NON_INTERACTIVE=anything returns false (interactive), where previously these fell through to CI/terminal detection. This is a semantic change for non-standard values. Only "1"/"true"/"0"/"false" are documented, so this is unlikely to bite anyone in practice, but a log.Printf("warning: unrecognized BD_NON_INTERACTIVE value %q, treating as interactive override", v) would help debugging. Not blocking.

Fix 2: --server flag in autostart lifecycle test ✅

Trivially correct. Commit a35edfd changed the default backend mode from server to embedded. The lifecycle test exercises dolt status/dolt start/dolt stop — commands that only exist in server mode. Adding --server to the bd init call is the minimal, correct fix. The test was never testing embedded mode; it was testing server lifecycle management.

Summary

No performance concerns. No new allocations or I/O in the hot path — isNonInteractiveInit is called once during init. Style is consistent with the existing codebase.