fix(setup-gbrain): document Windows MSYS quirks#1963
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Author
|
Verification from Mac mini catch-up lane:
GitHub currently reports no status check suite for this draft PR; Trunk merge queue comment is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1271.
This updates
/setup-gbrainfor the Windows MSYS/Git Bash quirks reported against gbrain v0.18.2:bun install --ignore-scriptson Windows shells, whilebun linkandgbrain init --pglitestill run later.exefallback for the local stdio MCP registration path whencommand -v gbraindoes not resolve the binaryclaude mcp listcan reportFailed to connectwhile the in-sessionmcp__gbrain__*tools workgbrain put "$SLUG" --content ...Tests / verification
bun test test/setup-gbrain-windows-msys-quirks.test.ts test/setup-gbrain-path4-structure.test.ts✅ 21 passgit diff --check -- setup-gbrain/SKILL.md setup-gbrain/SKILL.md.tmpl test/setup-gbrain-windows-msys-quirks.test.ts✅bun run gen:skill-docs --host all --dry-run✅ on the upstream-based branch before fork push rewrite; the fork-based branch reports stale generated host files becausemaxpetrusenkoagent/mainis behind upstream and this token cannot push workflow-file updates withoutworkflowscope. The PR diff againstgarrytan/gstack:mainremains limited tosetup-gbrain/SKILL.md,setup-gbrain/SKILL.md.tmpl, and the new regression test.bun run test:windowsbrowse/test/terminal-agent.test.tssource-guard failure in shard 5: the test expectsspawnClaude(in the message handler, while current source usesmaybeSpawnPty(...). Setup-gbrain focused tests still pass.Notes
No UI/API/deployment behavior changed. This is a skill-doc/template fix plus a source-level regression test for the Windows setup-gbrain contract.