Skip to content

fix(extract): resolve fs wikilinks against synced slugs#888

Closed
Cossackx wants to merge 1 commit into
garrytan:masterfrom
Cossackx:fix/fs-wikilink-slug-resolution
Closed

fix(extract): resolve fs wikilinks against synced slugs#888
Cossackx wants to merge 1 commit into
garrytan:masterfrom
Cossackx:fix/fs-wikilink-slug-resolution

Conversation

@Cossackx

@Cossackx Cossackx commented May 11, 2026

Copy link
Copy Markdown

Summary

  • Resolves fs-discovered Obsidian wikilinks against canonical synced slugs, not only raw relative paths.
  • Adds a per-run slug/title/alias resolver index for FS extraction.
  • Skips non-page/system/media targets and avoids guessing on ambiguous basename/title matches.

Why

Fixes #874.

Large Obsidian vaults often write links as [[resources/templates/README]], title-only links, or aliases while gbrain sync stores page slugs as normalized lowercase paths like resources/templates/readme. Native fs extraction could discover the wikilinks but fail to insert graph edges because resolution did not use the synced slug/title/alias namespace.

Test Plan

  • bun test test/extract.test.ts

Notes

  • This PR keeps ambiguous basename/title matches unresolved instead of choosing arbitrarily.
  • Direct markdown relative-path behavior remains covered by existing tests.

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@garrytan

garrytan commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Thanks for this contribution — and apologies for the slow triage. We did a full pass over the entire PR backlog. gbrain has moved fast, and the maintainer's larger "cathedral" rewrites have superseded a big share of community PRs: the AI gateway + recipes + user_provided_models system replaced almost all individual provider PRs; #1805 fixed the whole Postgres module-singleton class; #1542 unified the type taxonomy; #1657 the retrieval path; #1802 the doctor; and so on.

We're closing this one in that cleanup — either the fix already landed on master, it duplicates another PR or merged change, or it's outside the current merge bar. Where a closed PR carried a genuinely valuable idea, we've recorded it in docs/designs/COMMUNITY_IDEAS.md so nothing good is lost (a few may graduate into TODOs).

Please don't read the close as a judgment of the work — thank you for contributing. If you believe the underlying issue is still live on the latest master, reopen with a quick note and we'll take another look. 🙏

@garrytan garrytan closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs wikilink extraction should resolve against synced slugified page slugs

2 participants