fix: add recall and forget to CLI_ONLY set#792
Closed
garrytan-agents wants to merge 1 commit intogarrytan:masterfrom
Closed
fix: add recall and forget to CLI_ONLY set#792garrytan-agents wants to merge 1 commit intogarrytan:masterfrom
garrytan-agents wants to merge 1 commit intogarrytan:masterfrom
Conversation
v0.31 added recall and forget commands to the switch inside handleCliOnly() but didn't add them to the CLI_ONLY gate set. This caused both commands to fall through to the cliOps.get() lookup, which returns undefined → 'Unknown command' error. Fixes: gbrain recall, gbrain forget
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
v0.31 added
recallandforgetcommands in thehandleCliOnly()switch statement but forgot to add them to theCLI_ONLYgate set. Both commands fall through tocliOps.get()which returns undefined →Unknown command: recall.One-line fix: add both to the Set.
Testing
Before:
gbrain recall→ "Unknown command: recall"After:
gbrain recall→ hits the v0.31 recall handlerNeed help on this PR? Tag
@codesmithwith what you need.