feat: synthesize auto-enables when corpus dir is configured#764
Closed
garrytan-agents wants to merge 1 commit intogarrytan:masterfrom
Closed
feat: synthesize auto-enables when corpus dir is configured#764garrytan-agents wants to merge 1 commit intogarrytan:masterfrom
garrytan-agents wants to merge 1 commit intogarrytan:masterfrom
Conversation
Setting session_corpus_dir is now sufficient — enabled defaults to true when a corpus dir is configured, false otherwise. Explicit enabled=false still wins for users who want the corpus dir set but synthesis paused. Before: users had to set BOTH session_corpus_dir AND enabled=true, which was a silent footgun (configure corpus, expect dreams, nothing happens). - Reorder guard checks: corpus-dir check before enabled check - enabled=false is now 'explicitly false' in skip message - 5 unit tests covering all combinations - Update dream --help example to show corpus dir (not enabled)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Setting
session_corpus_diris now sufficient to enable dream synthesis. Previously users had to set bothsession_corpus_dirANDenabled=true, which was a silent footgun — you configure the corpus dir, expect dreams to work, and nothing happens.Changes
enableddefaults totruewhensession_corpus_diris set,falseotherwiseenabled=falsestill wins (for pausing synthesis without removing corpus config)dream --helpexampleTesting
Also tested in production: flipping enabled=true + Opus verdict model produced 18 new synthesis pages from a 92-transcript backfill.
Need help on this PR? Tag
@codesmithwith what you need.