fix(extract): skip _-prefixed directories in FS walker (#202)#263
Open
JiayuuWang wants to merge 1 commit into
Open
fix(extract): skip _-prefixed directories in FS walker (#202)#263JiayuuWang wants to merge 1 commit into
JiayuuWang wants to merge 1 commit into
Conversation
The FS walker in walkMarkdownFiles() skipped underscore-prefixed files but not underscore-prefixed directories, causing _pending/, _drafts/, etc. to be walked even though sync skips them via isSyncable(). Issue garrytan#202
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
walkMarkdownFiles()insrc/commands/extract.tsskips leading-underscore files (e.g.,_drafts/foo.md) but was not skipping leading-underscore directories (e.g.,_pending/,_drafts/). This caused extract to walk quarantine directories that sync correctly skips viaisSyncable().Fix
Added
if (entry.startsWith('_')) continue;before the directory recursion check, matching the file-level exclusion already present.Test
Added a test case that creates a
_pending/directory with a markdown file and assertspages_processed === 2(not 3) when running extract with--dry-run --json.Closes #202.