Skip to content

feat: support Ollama as embedding backend via environment variables#255

Closed
socamalo wants to merge 1 commit into
garrytan:masterfrom
socamalo:feat/ollama-embedding
Closed

feat: support Ollama as embedding backend via environment variables#255
socamalo wants to merge 1 commit into
garrytan:masterfrom
socamalo:feat/ollama-embedding

Conversation

@socamalo

Copy link
Copy Markdown

Summary

Add configurable embedding backend support for Ollama and other OpenAI-compatible embedding services via environment variables.

  • Supports GBRAIN_EMBEDDING_BASE_URL, GBRAIN_EMBEDDING_MODEL, GBRAIN_EMBEDDING_DIMENSIONS, GBRAIN_EMBEDDING_API_KEY
  • Adds docs/guides/ollama-embedding.md configuration guide

Changes

File Change
src/core/embedding.ts Ollama/OpenAI-compatible embedding backend support
src/core/config.ts Add embedding config to GBrainConfig
src/core/operations.ts Fix noEmbed detection for custom embedding backends
docs/guides/ollama-embedding.md New guide for Ollama configuration

Test plan

  • bun test passes
  • E2E tests pass
  • Verify Ollama embedding works with GBRAIN_EMBEDDING_BASE_URL=http://localhost:11434

Add configurable embedding backend support for Ollama and other
OpenAI-compatible embedding services.

Changes:
- src/core/embedding.ts: Support GBRAIN_EMBEDDING_BASE_URL,
  GBRAIN_EMBEDDING_MODEL, GBRAIN_EMBEDDING_DIMENSIONS,
  GBRAIN_EMBEDDING_API_KEY environment variables
- src/core/config.ts: Add embedding config to GBrainConfig
- src/core/operations.ts: Fix noEmbed detection for custom embedding backends
- docs/guides/ollama-embedding.md: New guide for Ollama configuration
@garrytan

garrytan commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Thanks for this contribution — and apologies for the slow triage. We did a full pass over the entire PR backlog. gbrain has moved fast, and the maintainer's larger "cathedral" rewrites have superseded a big share of community PRs: the AI gateway + recipes + user_provided_models system replaced almost all individual provider PRs; #1805 fixed the whole Postgres module-singleton class; #1542 unified the type taxonomy; #1657 the retrieval path; #1802 the doctor; and so on.

We're closing this one in that cleanup — either the fix already landed on master, it duplicates another PR or merged change, or it's outside the current merge bar. Where a closed PR carried a genuinely valuable idea, we've recorded it in docs/designs/COMMUNITY_IDEAS.md so nothing good is lost (a few may graduate into TODOs).

Please don't read the close as a judgment of the work — thank you for contributing. If you believe the underlying issue is still live on the latest master, reopen with a quick note and we'll take another look. 🙏

@garrytan garrytan closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants