Support writing page type inference#177
Closed
realriplab wants to merge 1 commit intogarrytan:masterfrom
Closed
Conversation
7 tasks
51333af to
9d08dd3
Compare
Owner
|
Closing — Two-line type inference change with no body or test plan. Thanks for taking the time to send a PR. If you'd like to rework this against current master with a clearer rationale and test plan, feel free to open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
writingtoPageType/writing/paths aswritingwriting/post.mdWhy
docs/GBRAIN_RECOMMENDED_SCHEMA.mddocuments awriting/directory, but runtime type inference defaulted those pages toconcept.Closes #176.
Validation
bun test test/markdown.test.tsbun test test/import-file.test.tsbun test test/slug-validation.test.ts