Skip to content

fix(cli): route calibration and search dashboard commands#1212

Closed
rivet-ops wants to merge 1 commit into
garrytan:masterfrom
rivet-ops:rivet/cli-routing-calibration-search
Closed

fix(cli): route calibration and search dashboard commands#1212
rivet-ops wants to merge 1 commit into
garrytan:masterfrom
rivet-ops:rivet/cli-routing-calibration-search

Conversation

@rivet-ops

Copy link
Copy Markdown

Summary

  • Route gbrain calibration through CLI-only dispatch.
  • Route gbrain search modes|stats|tune through the search dashboard without shadowing ordinary keyword search.
  • Ensure gbrain search modes --help prints dashboard help while gbrain search <query> --help still uses shared keyword-search help.
  • Add CLI integration coverage for calibration and search help routing.

Verification

  • git diff --check
  • Static scan of added lines for secrets / shell injection / eval / SQL injection: no matches
  • bun test test/cli.test.ts test/commands-search.test.ts test/search-mode.test.ts test/doctor-search-mode.test.ts --timeout 180000 — 87 pass / 0 fail
  • bun run verify — pass
  • Independent reviewer — pass; no security concerns or logic blockers

Notes

  • No Steward/Hunting write-capable GBrain MCP access was enabled.
  • No Brain promotion gates were bypassed.
  • No canonical Current Truth changes were made.

- Route calibration through CLI-only dispatch.
- Route search modes/stats/tune through dashboard dispatch without shadowing keyword search.
- Add CLI integration coverage for calibration and search help routing.
@garrytan

garrytan commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Thanks for this contribution — and apologies for the slow triage. We did a full pass over the entire PR backlog. gbrain has moved fast, and the maintainer's larger "cathedral" rewrites have superseded a big share of community PRs: the AI gateway + recipes + user_provided_models system replaced almost all individual provider PRs; #1805 fixed the whole Postgres module-singleton class; #1542 unified the type taxonomy; #1657 the retrieval path; #1802 the doctor; and so on.

We're closing this one in that cleanup — either the fix already landed on master, it duplicates another PR or merged change, or it's outside the current merge bar. Where a closed PR carried a genuinely valuable idea, we've recorded it in docs/designs/COMMUNITY_IDEAS.md so nothing good is lost (a few may graduate into TODOs).

Please don't read the close as a judgment of the work — thank you for contributing. If you believe the underlying issue is still live on the latest master, reopen with a quick note and we'll take another look. 🙏

@garrytan garrytan closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants