fix: register smoke-test in RESOLVER + add required SKILL sections

garrytan · claude · garrytan · commit 89a567e36d59 · 2026-04-23T22:29:51.000-07:00
Fixes the 7 failing unit tests + 1 failing Tier 1 E2E: - `skills/RESOLVER.md`: add smoke-test under Operational (mirrors skillpack-check placement). Fixes resolver_health check failure which cascaded into skillpack-check tests, doctor exit code, and the E2E 'gbrain doctor exits 0 on healthy DB' assertion. - `skills/smoke-test/SKILL.md`: add `## Anti-Patterns` and `## Output Format` sections required by skills-conformance.test.ts. Root cause: PR #369 added skills/smoke-test/ to the manifest but never wired it into RESOLVER.md and never added the sections the conformance test requires for every manifest entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
diff --git a/skills/RESOLVER.md b/skills/RESOLVER.md
@@ -54,6 +54,7 @@ This is the dispatcher. Skills are the implementation. **Read the skill file bef
 | "Create a skill", "improve this skill" | `skills/skill-creator/SKILL.md` |
 | "Skillify this", "is this a skill?", "make this proper" | `skills/skillify/SKILL.md` |
 | "Is gbrain healthy?", morning health check, skillpack-check | `skills/skillpack-check/SKILL.md` |
+| Post-restart health + auto-fix, "did the container restart break anything", smoke test | `skills/smoke-test/SKILL.md` |
 | Cross-modal review, second opinion | `skills/cross-modal-review/SKILL.md` |
 | "Validate skills", skill health check | `skills/testing/SKILL.md` |
 | Webhook setup, external event processing | `skills/webhook-transforms/SKILL.md` |
diff --git a/skills/smoke-test/SKILL.md b/skills/smoke-test/SKILL.md
@@ -132,3 +132,28 @@ fi
 - **Symptom:** Worker can't connect to DB
 - **Cause:** `GBRAIN_DATABASE_URL` not propagated to worker subprocess
 - **Auto-fix:** Script explicitly passes both `DATABASE_URL` and `GBRAIN_DATABASE_URL`
+
+## Anti-Patterns
+
+- ❌ Running smoke tests on every chat turn. Once per container restart (or
+  on user request) is plenty. The script is cheap but it's not free.
+- ❌ Writing a user drop-in without `timeout N` around any command that
+  could hang. A single hung drop-in stalls every subsequent run.
+- ❌ Auto-fixing without confirming the check is actually broken first.
+  The `pass → fail-detected → fix → re-test` loop is the contract; fixes
+  that skip the re-test can report success on a still-broken state.
+- ❌ Treating `skip` as `fail`. Missing prerequisites (no OpenClaw installed,
+  no brain repo configured) are skips, not failures. Exit code = count of
+  real failures, not skipped checks.
+- ❌ Hardcoding paths in a user drop-in. Read env vars
+  (`GBRAIN_DATABASE_URL`, `HOME`, etc.) so the script travels across
+  container rebuilds.
+
+## Output Format
+
+The script writes a one-line status per check to stdout (✅/❌/🔧/⏭️) plus a
+final summary line: `Results: N/M passed, F auto-fixed, S skipped`. A
+structured timestamped log appends to `$GBRAIN_SMOKE_LOG`
+(default `/tmp/gbrain-smoke-test.log`) for post-run forensics. Exit code
+equals the count of unfixed failures (0 = all pass, positive integer =
+count of remaining failures).
