FIX deprecated ndarray.tostring() -> tobytes() #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR updates deprecated NumPy array serialization method calls to maintain compatibility with NumPy 2.3, which removed the deprecated tostring() method.
- Replaces all instances of
ndarray.tostring()withndarray.tobytes()across multiple files - Ensures forward compatibility with newer NumPy versions while maintaining identical functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cortex/webgl/serve.py | Updates array serialization for base64 encoding in JSON serialization |
| cortex/freesurfer.py | Updates binary file writing operations for surface mesh data |
| cortex/formats.pyx | Updates STL file format writing functionality |
| cortex/dataset/braindata.py | Updates array hashing functionality |
Contributor
|
Thanks @hmac213! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all instances of ndarray.tostring() to ndarray.tobytes() for compatibility with NumPy 2.3, which removed the deprecated tostring() method.