MNT Remove dependency on distutils #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks great! Re your questions:
|
Contributor
|
I triggered the test on python 3.12, let's see |
Contributor
|
Alright, everything is green. I tried installing locally with a new conda environment and it works great. I'll merge and release a new version. Thanks @kroq-gar78 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove any explicit mentions of
distutilsand fix installation in Python 3.12.I'm not super familiar with the packaging system, so there's 2 things I'm not sure about:
<60.0? It looks like this was done to fix Installation trouble: ModuleNotFoundError: No module named 'distutils.msvccompiler' #552, but the NumPy migration docs suggest this is only if you're usingnumpy.distutils(which this PR removes).