Rename maintainers as editorial board#4273
Merged
shiltemann merged 6 commits intomainfrom Jul 19, 2023
Merged
Conversation
Collaborator
|
Thanks |
_plugins/author-page.rb
Outdated
| page2.data['news_count'] = news_by_author[contributor].length | ||
| page2.data['learning_pathways_count'] = learning_pathways_by_author[contributor].length | ||
|
|
||
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| t.fetch('editorial_board', []).include?(contributor) } |
Contributor
There was a problem hiding this comment.
📝 [rubocop] <Layout/SpaceInsideBlockBraces> reported by reviewdog 🐶
Space between { and | missing.
Suggested change
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| t.fetch('editorial_board', []).include?(contributor) } | |
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select { |t| t.fetch('editorial_board', []).include?(contributor) } |
_plugins/author-page.rb
Outdated
| page2.data['news_count'] = news_by_author[contributor].length | ||
| page2.data['learning_pathways_count'] = learning_pathways_by_author[contributor].length | ||
|
|
||
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| t.fetch('editorial_board', []).include?(contributor) } |
Contributor
There was a problem hiding this comment.
📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [133/120]
Suggested change
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| t.fetch('editorial_board', []).include?(contributor) } | |
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| | |
| t.fetch('editorial_board', []).include?(contributor) } |
_plugins/author-page.rb
Outdated
|
|
||
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| t.fetch('editorial_board', []).include?(contributor) } | ||
| # Also their learning pathways | ||
| page2.data['editors'] += site.pages.select {|t| t['layout'] == 'learning-pathway' && t.data.fetch('editorial_board', []).include?(contributor) } |
Contributor
There was a problem hiding this comment.
📝 [rubocop] <Layout/SpaceInsideBlockBraces> reported by reviewdog 🐶
Space between { and | missing.
Suggested change
| page2.data['editors'] += site.pages.select {|t| t['layout'] == 'learning-pathway' && t.data.fetch('editorial_board', []).include?(contributor) } | |
| page2.data['editors'] += site.pages.select { |t| t['layout'] == 'learning-pathway' && t.data.fetch('editorial_board', []).include?(contributor) } |
_plugins/author-page.rb
Outdated
|
|
||
| page2.data['editors'] = TopicFilter.enumerate_topics(site).select {|t| t.fetch('editorial_board', []).include?(contributor) } | ||
| # Also their learning pathways | ||
| page2.data['editors'] += site.pages.select {|t| t['layout'] == 'learning-pathway' && t.data.fetch('editorial_board', []).include?(contributor) } |
Contributor
There was a problem hiding this comment.
📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [152/120]
Suggested change
| page2.data['editors'] += site.pages.select {|t| t['layout'] == 'learning-pathway' && t.data.fetch('editorial_board', []).include?(contributor) } | |
| page2.data['editors'] += site.pages.select {|t| | |
| t['layout'] == 'learning-pathway' && t.data.fetch('editorial_board', []).include?(contributor) } |
Member
Author
|
ready to go @shiltemann |
shiltemann
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's closer to their functional role and it's a bit more of a recognisable in this sort of context, so hopefully encourages people to take on this role when possible. (I.e. a more CV-compatible title)
Additionally this recognises those contributors for going above and beyond, on their contributor profile page.