Replace previous box titles with more accessible version#3633
Merged
shiltemann merged 43 commits intomainfrom Oct 18, 2022
Merged
Replace previous box titles with more accessible version#3633shiltemann merged 43 commits intomainfrom
shiltemann merged 43 commits intomainfrom
Conversation
Which means it's a proper child of the blockquote, rather than conditionally a child based on if it's a button or not
shiltemann
approved these changes
Oct 18, 2022
Member
|
whoo!! 🎉 |
Member
|
💯 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the previous box titles which required one to type out a lot manually:
With a cleaner, "custom element"
Where the icon and styling is done automatically. This is done for all box types, and makes it easier to do bulk updates on them in the future if we need further changes.
It is backwards compatible, old style "icon tip ..." are still functional (until we get e.g. planemo updated + some of #2687 to provide suggestions)
accessibility
There are two a11y reasons to do this:
h3element, which constantly got flagged for incorrect trees of h1/2/3/4/..., having a transition fromh1toh3is bad, and anh3inside e.g. anh6section completely breaks the structure.hands on icon Hands-on: title, but we couldn't setaria=falseon all of those to make screenreaders ignore them. This allows us to finally do that.