Skip to content

Updating containers to Galaxy v20.05 +CI for pushing them#2025

Merged
hexylena merged 23 commits intogalaxyproject:masterfrom
bedroesb:Galaxy-docker-20.05
Sep 7, 2020
Merged

Updating containers to Galaxy v20.05 +CI for pushing them#2025
hexylena merged 23 commits intogalaxyproject:masterfrom
bedroesb:Galaxy-docker-20.05

Conversation

@bedroesb
Copy link
Contributor

@bedroesb bedroesb commented Aug 7, 2020

This PR will contain:

  • Dockerfiles at galaxy version v20.05
  • Improved starting of the database/Galaxy (needs further testing but worked well here)`
  • Nicer logging
  • Update documentation because password changed in 20.05
  • Github action that pushes a new version of the containers to Quay.io when a new version of GTN is released
    -> a job for every topic
  • Updating planemo template

@bedroesb
Copy link
Contributor Author

bedroesb commented Aug 10, 2020

I am already encountering the limitations of github actions (14gb is not enough to build and push some images) with big topics like, proteomics, transcriptomics etc ... these will still need to be pushed manually or to be moved to a Jenkins server.

@bedroesb bedroesb marked this pull request as ready for review August 10, 2020 19:14
@bedroesb bedroesb requested review from a team as code owners August 10, 2020 19:14
@bedroesb
Copy link
Contributor Author

can we put the github action yaml onto a whitelist of travis yaml linting?

@hexylena
Copy link
Member

@bedroesb sure. Just edit the makefile, maybe

- find . -name "*.yaml" | xargs -L 1 -I '{}' sh -c "yamllint {}" \
+ find . -name "*.yaml" | grep -v .github | xargs -L 1 -I '{}' sh -c "yamllint {}" \

@bedroesb
Copy link
Contributor Author

@hexylena Thank you! easy fix :)

@bedroesb
Copy link
Contributor Author

bedroesb commented Sep 7, 2020

@hexylena If there are no comments I think this is ready to be merged :)

hexylena
hexylena previously approved these changes Sep 7, 2020
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bedroesb this looks good :) Some small comments inline and one other: is it intended to remove krona.png? That looks a bit unexpected here.

Github actions look like a potentially great option.

# run tutorial install as user galaxy
su - $GALAXY_USER
# wait for database to finish starting up
STATUS=$(psql 2>&1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't psql hang if it's alive/working? Maybe psql -l would be better since you know that command terminates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took most if this part over from the galaxy-stable tools-wrapper (I am not super familiar with psql), because that was the only way I could successfully install the tools on the new versions of Galaxy. should we make edits there too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! That's unexpected. psql just opens an interactive postgres session, so it intentionally hangs forever waiting for user input. If it works there (and here) then no reason to change it. Just was surprising.

@bedroesb
Copy link
Contributor Author

bedroesb commented Sep 7, 2020

@hexylena Deleting that image was very sloppy of me, luckily you caught it!

@hexylena
Copy link
Member

hexylena commented Sep 7, 2020

@bedroesb honestly it shouldn't've passed travis, that image I think is used in the metagenomics intro slides. Weird! Oh well, looks good otherwise.

@hexylena hexylena merged commit 88e39b6 into galaxyproject:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants