Data fetched at docker run to decrease container size#1332
Data fetched at docker run to decrease container size#1332bgruening merged 9 commits intogalaxyproject:masterfrom
Conversation
|
if this idea will be implemented, we should also change planemo to generate the new docker files with the new lines |
|
@bgruening What do you think of this implementation? Or would you still prefer to incorporate this function inside the galaxy-stable base image. |
|
@bgruening do you think it is ready to go? |
|
I think this is a good improvement. @bedroesb can you fix the merge conflict? |
|
@bgruening I will, and I will also re-check everything |
|
@bgruening I checked the building of several topics, and it works like a charm. Only concern: when I wanted to build the containers in windows, I had some line ending problems in the bash scripts. (although on github LF is used ... ). But that is a windows thingy.. I think it can be merged. Biggest container now is 28 gig for transcriptomics (compared to ~80 before this update). |
topics/epigenetics/docker/Dockerfile
Outdated
| ADD bin/datalibrarydownload.sh /datalibrarydownload.sh | ||
| RUN /setup-tutorials.sh | ||
|
|
||
| ENTRYPOINT ["/datalibrarydownload.sh"] No newline at end of file |
There was a problem hiding this comment.
That is a little bit nitpicking, but could you call this script data_libarary_download.sh. Its a little bit more readbale.
|
@bgruening Done ! |
|
Merci! |
|
@bedroesb you might want to inform Frederik about this. He probably wants to put this in some fancy GDoc for ELIXIR. |
At image build,
docker build -t containername -f topics/topicname/docker/Dockerfile ., only the data-library.yaml files are merged, the way it used to, but the data itself is not downloaded.When you use the normal run command
docker run -p "8080:80" containernamethe container will run without the example data.When the command
docker run -p "8080:80" containername -dis used, the corresponding data libraries of that topic will be downloaded and accessible within the training environment.This reduces the size of the images enormously, enabling them to be uploaded to docker hub or quay.io