Merged
Conversation
bgruening
reviewed
Dec 29, 2019
Member
bgruening
left a comment
There was a problem hiding this comment.
planemo/galaxy/test/.actions.py.swp
Should that file be removed?
d46aa9a to
e018cd8
Compare
mvdbeek
approved these changes
Dec 29, 2019
Member
mvdbeek
left a comment
There was a problem hiding this comment.
Good refactorings! One thing to keep in mind is that watchdog might monitor tool directories recursively (not sure anymore what the rules are for this), that might also lead to open files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently observed a
to many open fileserror on a largeplanemo testrun (with ubuntu's default limit of 1024 files .. with 4k the problem did not appear). So lets try if closing all open files helps.