Build single requirement container, log if requirement not in best-practice channels#977
Merged
mvdbeek merged 4 commits intogalaxyproject:masterfrom Dec 18, 2019
Merged
Conversation
db0627e to
9b2f01c
Compare
9b2f01c to
326af18
Compare
bgruening
reviewed
Dec 14, 2019
bgruening
reviewed
Dec 18, 2019
| contents = ",".join(target_strings) | ||
| f.write(contents) | ||
| ctx.vlog("Wrote requirements [%s] to file [%s]" % (contents, target_filename)) | ||
| with open(target_filename, "a") as f: |
Member
There was a problem hiding this comment.
I guess if the file already exists we should not append, isn't it? Is a really needed here?
Member
Author
There was a problem hiding this comment.
It's a leftover from appending to hash.tsv
bgruening
approved these changes
Dec 18, 2019
Member
|
@mvdbeek I think we need a new planemo release. Then we could start testing and migrating the monitor repo ... |
Member
Author
|
We need to wait for the cwltool upgrade so that we can use a yet-to-be released galaxy-tool-util package with the mulled updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also revealed quite a headache: We frequently don't specify exact versions in tool requirements (e.g
<requirement type="package" version="3.7">conda</requirement>) instead of the full 3.7.1. This is very widespread in Galaxy tools. A single requirement like this will prevent building a container :(.