Implement github workflow and fix profile commands if psql unavailable #976
Implement github workflow and fix profile commands if psql unavailable #976jmchilton merged 7 commits intogalaxyproject:masterfrom
Conversation
Runs docstring tests only on travis-ci, github workflows has no allow failure mode.
and unicodify running container list.
|
workflow for this commit is running at: https://github.com/mvdbeek/planemo/commit/0298f8494ce4fe36f681ec5f9a53fd83b0bc1bb1/checks?check_suite_id=347681728 |
|
Amazing! |
|
Have you seen tox-gh-actions? galaxyproject/gxformat2@fea27f0 There isn't a ton of cruft doing it explicitly the way you have here - so I'm not sure it is worth introducing the black box magic tox-gh-actions does. But the magic is kind of cool at the same time. Update: It is a cool way to skip running the doc tests and readme test on all but one profile, lint only on the earliest and latest version, and then actually run the tests on more versions? Something to consider |
The speed should be worth the blackbox I think. 👍 |
|
I don't think it is, we're talking seconds for readme compared to ~1 hour in total build time. |
|
Sorry, I am thinking Galaxy, where linting is long. 🙈 |
|
Still makes sense to look into it if we also want to test a wider range of python versions, we could skip the full-blown serve tests there |
No description provided.